sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-502 Refactor "show connector" command
Date Wed, 11 Jul 2012 06:50:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5887/#review9050
-----------------------------------------------------------

Ship it!


Looks good to me Bilung, I'll commit it shortly.

- Jarek Cecho


On July 10, 2012, 9:42 p.m., Bilung Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5887/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 9:42 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Refactor the "show connector" command.
> 
> 
> This addresses bug SQOOP-502.
>     https://issues.apache.org/jira/browse/SQOOP-502
> 
> 
> Diffs
> -----
> 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
1346760 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java
1346760 
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 1346760

>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/connector/ConnectorError.java
1346760 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
1346760 
>   /branches/sqoop2/server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
1346760 
> 
> Diff: https://reviews.apache.org/r/5887/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bilung Lee
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message