sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-495: Support for parameter substitution in the client shell.
Date Mon, 16 Jul 2012 13:03:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5934/#review9169
-----------------------------------------------------------

Ship it!


Hi Vasanth,
thank you very much for your patch. Your changes looks go to me - I just have couple of nits:


/branches/sqoop2/client/src/main/java/org/apache/sqoop/client/core/ClientError.java
<https://reviews.apache.org/r/5934/#comment19603>

    Can you please remove trailing spaces?



/branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java
<https://reviews.apache.org/r/5934/#comment19605>

    Can you please remove trailing spaces?



/branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java
<https://reviews.apache.org/r/5934/#comment19606>

    Is different indentation here on purpose?


Please attach updated patch to the JIRA and I'll commit it.

- Jarek Cecho


On July 13, 2012, 7:44 p.m., vasanthkumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5934/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 7:44 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Support for parameter substitution in the client shell.
> 
> sqoop:000> host="local"
> sqoop:000> set server -h ${host}
> Server is set successfully.
> 
> sqoop:000> show server -a
> Server host: local
> Server port: 8080
> Server webapp: sqoop
> 
> sqoop:000> 
> 
> 
> This addresses bug SQOOP-495.
>     https://issues.apache.org/jira/browse/SQOOP-495
> 
> 
> Diffs
> -----
> 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/core/ClientError.java
1359824 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java
1359824 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java
1359824 
> 
> Diff: https://reviews.apache.org/r/5934/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> vasanthkumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message