sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arvind Prabhakar" <arv...@apache.org>
Subject Re: Review Request: SQOOP-491. Add comments to configuration entries
Date Wed, 18 Jul 2012 16:08:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6018/
-----------------------------------------------------------

(Updated July 18, 2012, 4:08 p.m.)


Review request for Sqoop and Bilung Lee.


Changes
-------

Thanks for the review Jarcec. Updated the diff with trailing spaces removed.


Description
-------

The original Jira was about creating a top-level configuration directory, but one already
exists under dist/src/main directory. I have therefore added the comments to the configuration
files present in this directory.


This addresses bug SQOOP-491.
    https://issues.apache.org/jira/browse/SQOOP-491


Diffs (updated)
-----

  /branches/sqoop2/dist/src/main/server/conf/sqoop.properties 1362634 
  /branches/sqoop2/dist/src/main/server/conf/sqoop_bootstrap.properties 1362634 

Diff: https://reviews.apache.org/r/6018/diff/


Testing
-------

Built the system and verified that the configuration files were present in generated dist
tarball.


Thanks,

Arvind Prabhakar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message