sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-519 Update the version of hsqldb decadency to 2.0.0
Date Wed, 25 Jul 2012 18:12:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6130/
-----------------------------------------------------------

(Updated July 25, 2012, 6:12 p.m.)


Review request for Sqoop, Jarek Cecho and Bilung Lee.


Changes
-------

I found a typo in comment... Fixed.


Description
-------

Updated the version of Hsqldb dependency to 2.2.8. This is needed because Hadoop YARN bundles
Hsqldb 2.0.0, and Hsqldb 1.8.2-compiled Sqoop does not work when Hsqldb 2.0.0 or higher is
present in classpath. But Hsqldb 2.2.8-compiled Sqoop works.

The reason why I bumped to 2.2.8 instead of 2.0.0 is that 2.2.8 seems more stable than 2.0.0
according to hsqldb.org:

>> HyperSQL v. 2.2.8 is the latest release in the 2.x series and should be used in preference
to earlier 2.0 and 2.x releases.

In addition, 2.0.0 makes TestExportUpdate fail.

Changing the version of Hsqldb dependency breaks several unit test cases, so I included fixes
to those in this patch as well.


This addresses bug SQOOP-519.
    https://issues.apache.org/jira/browse/SQOOP-519


Diffs (updated)
-----

  /trunk/ivy.xml 1365675 
  /trunk/ivy/libraries.properties 1365675 
  /trunk/ivy/sqoop-test.xml 1365675 
  /trunk/ivy/sqoop.xml 1365675 
  /trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1365675 
  /trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/TestAvroExport.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/TestAvroImport.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/TestExport.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/TestMultiCols.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/manager/OracleExportTest.java 1365675 
  /trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1365675

  /trunk/src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1365675 

Diff: https://reviews.apache.org/r/6130/diff/


Testing
-------

ant test
ant test -Dthirdparty=true
ant checkstyle

My focus was getting tests passing ASAP. Please review carefully and let me know if you have
a better way to fix.


Thanks,

Cheolsoo Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message