sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload
Date Wed, 25 Jul 2012 23:15:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2724/#review9486
-----------------------------------------------------------


Hi Masatake,
thank you very much for your effort in creating this connector. I'm extremely sorry that I
did not provide feedback sooner.  Please let me know if you're still willing to work on it
as I would like to get it committed at some point. I did just quickly read your changes and
I do have few high level comments for now:

1) Can you please move all your classes into org.apache.sqoop instead of com.cloudera.sqoop?

2) Could you please change all license files from Cloudera to Apache Software Foundation?


/src/java/com/cloudera/sqoop/manager/PGBulkloadManager.java
<https://reviews.apache.org/r/2724/#comment20299>

    Please move this to the PGBulkloadExportJob. We've recently introduced method propagateOptionsToJob()
that you can override and that should serve exactly this purpose.


Again, please accept my deep apology for not getting back to you for so long.

Jarcec

- Jarek Cecho


On April 2, 2012, 2:30 a.m., Masatake Iwasaki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2724/
> -----------------------------------------------------------
> 
> (Updated April 2, 2012, 2:30 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Patch for SQOOP-390
> https://issues.apache.org/jira/browse/SQOOP-390
> 
> 
> This addresses bug SQOOP-390.
>     https://issues.apache.org/jira/browse/SQOOP-390
> 
> 
> Diffs
> -----
> 
>   /src/java/com/cloudera/sqoop/manager/PGBulkloadManager.java PRE-CREATION 
>   /src/java/com/cloudera/sqoop/mapreduce/AutoProgressReducer.java PRE-CREATION 
>   /src/java/com/cloudera/sqoop/mapreduce/PGBulkloadExportJob.java PRE-CREATION 
>   /src/java/com/cloudera/sqoop/mapreduce/PGBulkloadExportMapper.java PRE-CREATION 
>   /src/java/com/cloudera/sqoop/mapreduce/PGBulkloadExportReducer.java PRE-CREATION 
>   /src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/2724/diff/
> 
> 
> Testing
> -------
> 
> This patch include the test class PGBulkloadManagerTest.
> I've tested "ant test" and passed.
> 
> 
> Thanks,
> 
> Masatake Iwasaki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message