sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhijeet Gaikwad" <abygaikwa...@gmail.com>
Subject Re: Review Request: SQOOP-529: Enforce usage of --driver and --connection-manager parameters
Date Wed, 01 Aug 2012 16:51:39 GMT


> On Aug. 1, 2012, 4:11 a.m., Abhijeet Gaikwad wrote:
> > /src/java/org/apache/sqoop/manager/DefaultManagerFactory.java, line 42
> > <https://reviews.apache.org/r/6250/diff/1/?file=131540#file131540line42>
> >
> >     I think this whole change is not required here. The control flows here only
if manualDriver and mangerClassName are NULL. Let me know if I am missing anything.
> 
> Jarek Cecho wrote:
>     I'm little bit confused here. I've removed that piece of code because it won't do
anything as the managerClassName is being NULL.
>     
>     Maybe let me provide you some background for this change for better understanding.
I've moved --driver and --connection-manager parameter handling out of DefaultManagerFactory
to ConnFactory class. That's why this code is removed from DefaultManagerFactory. My rationale
here is that user can configure additional factories and those factories than do have ability
to suppress handling of --driver and --connection-manager parameters. And I do not believe
that it's valid behavior.

Pardon me this is my bad. Just getting used to Review board. I thought this was added, but
again my sincere apologies, that was silly of me.


- Abhijeet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6250/#review9674
-----------------------------------------------------------


On Aug. 1, 2012, 4:03 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6250/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 4:03 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've refactored the code in the way I've designed in the JIRA.
> 
> 
> This addresses bug SQOOP-529.
>     https://issues.apache.org/jira/browse/SQOOP-529
> 
> 
> Diffs
> -----
> 
>   /src/java/org/apache/sqoop/ConnFactory.java 1367605 
>   /src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 1367605 
> 
> Diff: https://reviews.apache.org/r/6250/diff/
> 
> 
> Testing
> -------
> 
> ant tests passes
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message