sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-529: Enforce usage of --driver and --connection-manager parameters
Date Thu, 02 Aug 2012 00:37:58 GMT


> On Aug. 1, 2012, 6:37 p.m., Abhijeet Gaikwad wrote:
> > Last two comments on the Logs, if possible please incorporate them. No need of uploading
new diff, I am good with the functionality changes.
> > "ant test -Dhadoopversion=100" ran a success for me.
> > 
> > Thanks for the patch.

Updated version has been attached to the JIRA.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6250/#review9696
-----------------------------------------------------------


On Aug. 1, 2012, 4:03 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6250/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 4:03 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've refactored the code in the way I've designed in the JIRA.
> 
> 
> This addresses bug SQOOP-529.
>     https://issues.apache.org/jira/browse/SQOOP-529
> 
> 
> Diffs
> -----
> 
>   /src/java/org/apache/sqoop/ConnFactory.java 1367605 
>   /src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 1367605 
> 
> Diff: https://reviews.apache.org/r/6250/diff/
> 
> 
> Testing
> -------
> 
> ant tests passes
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message