sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-544: Split job metadata for different job types (import, export)
Date Tue, 14 Aug 2012 17:45:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6576/#review10288
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Aug. 13, 2012, 1:22 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6576/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 1:22 p.m.)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Description
> -------
> 
> Job covered by this JIRA:
> 
> * I've included new abstraction classes for connection and job (MConnection, MJob). Both
are internally represented as List<MForm>.
> * I've included support for multiple job types (Import, Export). Solution should be open
to any other new job types.
> * I'm forcing connector to supply only one set of Forms for each job type (e.g. support
IMPORT twice is incorrect usage).
> 
> Jarcec
> 
> 
> This addresses bug SQOOP-544.
>     https://issues.apache.org/jira/browse/SQOOP-544
> 
> 
> Diffs
> -----
> 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
1372400 
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 1372400

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnection.java PRE-CREATION

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnector.java 1372400

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MFramework.java 1372400

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MJob.java PRE-CREATION

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MStringInput.java 1372400

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/ModelError.java PRE-CREATION

>   /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
PRE-CREATION 
>   /branches/sqoop2/common/src/test/java/org/apache/sqoop/model/TestMFramework.java PRE-CREATION

>   /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
1372400 
>   /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java
1372400 
>   /branches/sqoop2/connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java
1372400 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
1372400 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
1372400 
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
1372400 
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
1372400 
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
1372400 
>   /branches/sqoop2/spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java
1372400 
> 
> Diff: https://reviews.apache.org/r/6576/diff/
> 
> 
> Testing
> -------
> 
> * Added new test for MFramework instance creation
> * mvn test
> * "Life" testing 
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message