sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-577: Design storage in derby repository for connect and job metadata
Date Tue, 21 Aug 2012 22:12:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6626/#review10594
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Aug. 15, 2012, 8:53 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6626/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 8:53 a.m.)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Description
> -------
> 
> I've designed 4 new tables:
> 
> * SQ_CONNECTION: Keep track of all created connections
> * SQ_JOB: Keep track of all created jobs
> * SQ_CONNECTION_INPUT: N:M relationship between SQ_CONNECTION and SQ_INPUT to save actual
values that user has entered
> * SQ_JOB_INPUT: N:M relationship between SQ_JOB and SQ_INPUT to save actual values that
user has entered
> 
> Some additional comments:
> 
> * I've decided for initial Sqoop2 version to represent all metadata values in repository
as strings. My intention is to use MInput methods getUrlSafeValueString and restoreFromUrlSafeValueString
to serialize data into string and to retrieve them back. I'm planning to create follow up
JIRA to improve this representation by having different tables for different MInput implementations
in case that this proposal will get accepted.
> 
> 
> This addresses bug SQOOP-577.
>     https://issues.apache.org/jira/browse/SQOOP-577
> 
> 
> Diffs
> -----
> 
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
1373244 
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
1373244 
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
1373244 
>   /branches/sqoop2/spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java
1373244 
> 
> Diff: https://reviews.apache.org/r/6626/diff/
> 
> 
> Testing
> -------
> 
> Manual run to see that those new tables will be correctly created.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message