sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-497: Enhance repository interface to support Connection CRUD
Date Tue, 21 Aug 2012 22:25:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6630/#review10595
-----------------------------------------------------------


For some reason, I can't apply your patch cleanly.  Could you please double check?  Thanks.

- Bilung Lee


On Aug. 15, 2012, 12:12 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6630/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 12:12 p.m.)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Description
> -------
> 
> This patch consists of two parts:
> 
> * Moving original MConnection and MJob structures to classes MConnectionForms and MJobForms
and creating standalone MConnection and MJob structures that represents entire connection
or job (e.g. for connection, MConnection wraps two MConnectionForms structures - one for connector
and second for framework part).
> * Proposing new methods to repository interface for CRUD on new MConnection objects
> 
> 
> This addresses bug SQOOP-497.
>     https://issues.apache.org/jira/browse/SQOOP-497
> 
> 
> Diffs
> -----
> 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
1373275 
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 1373275

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnection.java 1373275

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnectionForms.java
PRE-CREATION 
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnector.java 1373275

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MFramework.java 1373275

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MJob.java 1373275 
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MJobForms.java PRE-CREATION

>   /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
1373275 
>   /branches/sqoop2/common/src/test/java/org/apache/sqoop/model/TestMFramework.java 1373275

>   /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
1373275 
>   /branches/sqoop2/connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java
1373275 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
1373275 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
1373275 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
1373275 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/Repository.java 1373275

>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
1373275 
>   /branches/sqoop2/spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java
1373275 
> 
> Diff: https://reviews.apache.org/r/6630/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done, no new unit tests included.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message