sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-576: Implement command "show framework" end to end
Date Mon, 27 Aug 2012 17:19:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6745/#review10778
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Aug. 23, 2012, 7:08 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6745/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 7:08 a.m.)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Description
> -------
> 
> I've implemented show framework command from end to end.
> 
> 
> This addresses bug SQOOP-576.
>     https://issues.apache.org/jira/browse/SQOOP-576
> 
> 
> Diffs
> -----
> 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/display/FormDisplayer.java
PRE-CREATION 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/request/FrameworkRequest.java
PRE-CREATION 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
1376378 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
1376378 
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java
PRE-CREATION 
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 1376378

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/FrameworkBean.java PRE-CREATION

>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
PRE-CREATION 
>   /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java
PRE-CREATION 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
1376378 
>   /branches/sqoop2/server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
PRE-CREATION 
>   /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/v1/FrameworkServlet.java
PRE-CREATION 
>   /branches/sqoop2/server/src/main/webapp/WEB-INF/web.xml 1376378 
> 
> Diff: https://reviews.apache.org/r/6745/diff/
> 
> 
> Testing
> -------
> 
> - I've done manual testing (trying command "show framework" in client).
> - Some minor unit tests are included
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message