sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhijeet Gaikwad (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-579) Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse
Date Sun, 19 Aug 2012 08:48:38 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437483#comment-13437483
] 

Abhijeet Gaikwad commented on SQOOP-579:
----------------------------------------

Looks good. 
Just one minor change: extractSchemeFrom() name seems incomplete, can you change it to extractSchemeFromJDBCUrl()
or maybe extractScheme(). Please upload the new patch.

Thanks.
                
> Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods
for reuse
> ------------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-579
>                 URL: https://issues.apache.org/jira/browse/SQOOP-579
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: connectors
>    Affects Versions: 1.4.1-incubating
>            Reporter: Seetharam Venkatesh
>            Assignee: Seetharam Venkatesh
>            Priority: Minor
>         Attachments: SQOOP-579.patch
>
>
> Would like to extract couple of code fragments into methods so custom manager factories
can reuse 'em.
> * Extracting scheme from options
> * factory method for doling out a connection manager for a given class name

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message