sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Robson" <david.rob...@quest.com>
Subject Re: Review Request: In-process Hive CLI driver does not work
Date Wed, 19 Sep 2012 06:02:48 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 19, 2012, 6:02 a.m.)

Review request for Sqoop.


Remove fragment identified by Jarcec.


Throw the exception from the old namespace to support anyone checking the old exception. Also
update HiveImport to check the new namespace.

This addresses bug SQOOP-607.

Diffs (updated)

  src/java/org/apache/sqoop/util/SubprocessSecurityManager.java 4951627 

Diff: https://reviews.apache.org/r/7143/diff/


Created a mock Hive CLI that calls System.exit(0). Can see it now works.
Was trying to create an automated test but the problem was once I created the mock class it
was used for the other tests as well instead of the shell script.
The easiest way I can see to create a unit test would be to allow the Hive CLI class to be
specified as a parameter - that way it could be overridden in a unit test to a mock class.
Was also thinking about loading the class at runtime but this seemed like a bit of work for
a small bug fix.


David Robson

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message