sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Review Request: SQOOP-603: Support small intervals in IntegerSplitter implementation
Date Thu, 20 Sep 2012 15:37:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7193/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've decided to alter method split() to add one maxVal in case that there is less or equal
split points then requested split count.


This addresses bug SQOOP-603.
    https://issues.apache.org/jira/browse/SQOOP-603


Diffs
-----

  src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 35b74eb 
  src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java 8e7a096 
  src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java 22d5140 

Diff: https://reviews.apache.org/r/7193/diff/


Testing
-------

* ant test
* Real MySQL instance in couple of scenarios


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message