sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-540: Microsoft SQL Connector doesn't support custom schemas
Date Mon, 01 Oct 2012 22:18:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7369/
-----------------------------------------------------------

(Updated Oct. 1, 2012, 10:18 p.m.)


Review request for Sqoop.


Changes
-------

I've incorporated Cheolsoo's comments.


Description
-------

I've chosen similar implementation path as was used in PostgreSQL Connector.


This addresses bug SQOOP-540.
    https://issues.apache.org/jira/browse/SQOOP-540


Diffs (updated)
-----

  src/java/org/apache/sqoop/manager/SQLServerManager.java 7ce1edd 
  src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java a6e5546 
  src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java a56b93d 
  src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java PRE-CREATION 
  src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 0f949f4 

Diff: https://reviews.apache.org/r/7369/diff/


Testing
-------

I've test my changes (both import and export) against Microsoft SQL Server Express 2012.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message