sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-619: Display user persistent id of newly created connection and job objects
Date Fri, 05 Oct 2012 20:13:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7410/#review12197
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Oct. 4, 2012, 1:01 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7410/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 1:01 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've improved VerificationBean to also transfer ID if it's present and fixed user code
to display it.
> 
> 
> This addresses bug SQOOP-619.
>     https://issues.apache.org/jira/browse/SQOOP-619
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 9716de6

>   client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 6c579d0 
>   client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 904624c

>   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 1a8b901 
>   common/src/main/java/org/apache/sqoop/json/ValidationBean.java b56f6ed 
> 
> Diff: https://reviews.apache.org/r/7410/diff/
> 
> 
> Testing
> -------
> 
> I've performed just manual testing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message