sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-467 Add support for Oracle BINARY_FLOAT and BINARY_DOUBLE data types
Date Thu, 01 Nov 2012 23:46:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7828/
-----------------------------------------------------------

(Updated Nov. 1, 2012, 11:46 p.m.)


Review request for Sqoop and Jarek Cecho.


Changes
-------

After discussion with Jarcec, I removed place-holder methods in SqlManager.


Description
-------

Re-based my old patch to trunk.


This addresses bug SQOOP-467.
    https://issues.apache.org/jira/browse/SQOOP-467


Diffs (updated)
-----

  src/java/org/apache/sqoop/manager/MySQLManager.java a3f586a 
  src/java/org/apache/sqoop/manager/OracleManager.java 6974e1b 
  src/java/org/apache/sqoop/manager/SqlManager.java 3a52c6d 
  src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 309a960 

Diff: https://reviews.apache.org/r/7828/diff/


Testing
-------

ant test
ant test -Dthridparty=true

I added two test cases - one for BINARY_FLOAT and one for BINARY_DOUBLE - to the OracleCompatTest
suite.


Thanks,

Cheolsoo Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message