sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-650: Add ability to name mapreduce job generated by Sqoop
Date Wed, 07 Nov 2012 00:01:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7706/#review13188
-----------------------------------------------------------

Ship it!


Hi Jarcec,

I have a minor comment below. If you can upload a new patch to the jira, I will commit it
after running tests.

Thanks!


src/java/org/apache/sqoop/tool/ExportTool.java
<https://reviews.apache.org/r/7706/#comment28360>

    Can you please fix the indentation in these lines?


- Cheolsoo Park


On Oct. 23, 2012, 2:39 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7706/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 2:39 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added new extra parameter and made sure that it will be propagated to all places
where Sqoop is creating mapreduce job.
> 
> 
> This addresses bug SQOOP-650.
>     https://issues.apache.org/jira/browse/SQOOP-650
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/SqoopOptions.java 92c9996 
>   src/java/org/apache/sqoop/mapreduce/ExportJobBase.java b9eaa83 
>   src/java/org/apache/sqoop/mapreduce/ImportJobBase.java efc2c37 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 0c9cda6 
>   src/java/org/apache/sqoop/tool/ExportTool.java 494887d 
>   src/java/org/apache/sqoop/tool/ImportTool.java 415b315 
> 
> Diff: https://reviews.apache.org/r/7706/diff/
> 
> 
> Testing
> -------
> 
> I've tested it on real hadoop cluster. I did not included any test cases as I'm not sure
how to actually test this automatically.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message