sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-694 Introduce client "verbose" mode
Date Wed, 14 Nov 2012 04:48:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8045/#review13415
-----------------------------------------------------------


Thanks for the patch.  One comment below.


client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
<https://reviews.apache.org/r/8045/#comment28752>

    Need a license header for this file.


- Bilung Lee


On Nov. 14, 2012, 1:43 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8045/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 1:43 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've implemented rather general option on client to set various options and provided
first implementation for "verbose" mode.
> 
> 
> This addresses bug SQOOP-694.
>     https://issues.apache.org/jira/browse/SQOOP-694
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Environment.java aa8c989e14780e5a4f627100b495d34839c6c850

>   client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java 377c827bc89816f1d317c84778feb9acaa8c423d

>   client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java PRE-CREATION

>   client/src/main/java/org/apache/sqoop/client/utils/ThrowableDisplayer.java c8f8223d63db53575537358fa7e087396cd5863a

> 
> Diff: https://reviews.apache.org/r/8045/diff/
> 
> 
> Testing
> -------
> 
> Tested on real cluster.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message