sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-719 Improve user experience with addtowar.sh script in Sqoop 2
Date Mon, 26 Nov 2012 17:04:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8173/#review13736
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Nov. 22, 2012, 12:40 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8173/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2012, 12:40 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added following abilities to the addtowar.sh script:
> 
> * Print out all jars that we're adding to war file
> * Allow specifying multiple hadoop paths (which is the case of Hadoop 2)
> * Introduce basic "auto hadoop version detection" as an optional way
> * Support for CDH3 and CDH4MR1 (my rationale is that cdh users are majority of Sqoop
users and this distribution specific code is only about 4 lines of code in script that is
suppose to run once during installation)
> 
> 
> This addresses bug SQOOP-719.
>     https://issues.apache.org/jira/browse/SQOOP-719
> 
> 
> Diffs
> -----
> 
>   dist/src/main/bin/addtowar.sh fb65d351a7d265fee899ac14cb5c6297c5b5d56a 
> 
> Diff: https://reviews.apache.org/r/8173/diff/
> 
> 
> Testing
> -------
> 
> I've tested script on all supported Hadoop distributions.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message