sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-726 Put debugging information into generated SqoopRecord class
Date Sat, 01 Dec 2012 00:02:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8234/#review13926
-----------------------------------------------------------

Ship it!


LGTM. I will commit it after running unit test.

- Cheolsoo Park


On Nov. 27, 2012, 3:46 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8234/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2012, 3:46 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've add proposed two fields as a comment entries into generated class.
> 
> 
> This addresses bug SQOOP-726.
>     https://issues.apache.org/jira/browse/SQOOP-726
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/orm/ClassWriter.java f456e9922b46cf45cfa66e8bb1049114c06de55e

> 
> Diff: https://reviews.apache.org/r/8234/diff/
> 
> 
> Testing
> -------
> 
> Tests are passing and I've checked change on real life cluster.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message