sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Review Request: SQOOP-739 Connectors in Sqoop 2 should be versionable
Date Wed, 05 Dec 2012 01:25:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8347/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've extended connector interface to require a string based version.


This addresses bug SQOOP-739.
    https://issues.apache.org/jira/browse/SQOOP-739


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 734276dfdd88b121c64a608cb79db2f10900ae4b

  client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 0b685bf1ab4e783a654cfc4b5737efb8fc23a566

  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java ac2683cc0a23cceb0b925e1c489217adb4a7b211

  common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 82d865ce602a4e6abf9656c9f6809d2827868000

  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 732293a745e65aaeb8b05ce36f514ac53da287d7

  common/src/main/java/org/apache/sqoop/model/MConnector.java 5b3b8840362e3b297364b0c47e7beddb634b2b4b

  common/src/test/java/org/apache/sqoop/json/TestUtil.java 791e9990bea77b6595a57c3b36d0c41ea3e217a7

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
26daaf7296390f9765f0210196b7d7414d816ac9 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 00315eaf7e8dcae9896bd1de847a5e3adccc56f6

  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
b9ba7466509a2008b39a8e5d73ae128bead4bf85 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
1d1fc09cc11d261595b982250400f823647c9f10 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
f836500c8d6f6f592dd5537237c0f63ed56183a5 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
0efa19dc9604f04736ab3c1da7c059d634073f75 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 52d08521245b248f9a0bf2d5b8c05b7854572697


Diff: https://reviews.apache.org/r/8347/diff/


Testing
-------

Unit tests seems to be passing and I've tested it on real cluster.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message