-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8347/#review14219
-----------------------------------------------------------
Ship it!
Ship It!
- Bilung Lee
On Dec. 8, 2012, 3:33 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8347/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2012, 3:33 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've extended connector interface to require a string based version.
>
>
> This addresses bug SQOOP-739.
> https://issues.apache.org/jira/browse/SQOOP-739
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java ac2683c
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 82d865c
> common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 732293a
> common/src/main/java/org/apache/sqoop/model/MConnector.java 5b3b884
> common/src/test/java/org/apache/sqoop/json/TestUtil.java 791e999
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
26daaf7
> core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 00315ea
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
b9ba746
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
1d1fc09
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
f836500
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
0efa19d
> spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 52d0852
>
> Diff: https://reviews.apache.org/r/8347/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tested it on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>
|