sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Re: Review Request: SQOOP-766 Sqoop2: Fix client resources
Date Wed, 12 Dec 2012 19:58:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8557/#review14370
-----------------------------------------------------------

Ship it!


Looks good.  Thanks for cleaning this up.  

- Venkat Ranganathan


On Dec. 12, 2012, 7:54 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8557/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 7:54 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've fixed small nits and removed unnecessary empty lines.
> 
> 
> This addresses bug SQOOP-766.
>     https://issues.apache.org/jira/browse/SQOOP-766
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 72fe91c409433d2c52e5ef01083e284d1e3e8dc0

>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 259739ae41b2b03cc971b2e0bb41b1a830f6ddc2

>   client/src/main/resources/client-resource.properties a65b37e196b2397655c0255f33a9ebd7d86680fd

> 
> Diff: https://reviews.apache.org/r/8557/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message