sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Re: Review Request: SQOOP-762 Sqoop2: Improve logging in mapreduce execution engine
Date Thu, 13 Dec 2012 02:09:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8562/#review14415
-----------------------------------------------------------

Ship it!


Looks good.  I thought whether we wanted INFO as the root logger level, but this being development
release, DEBUG is more helpful

- Venkat Ranganathan


On Dec. 13, 2012, 1:29 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8562/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 1:29 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added:
> * A lot of log messages on various classes in execution engine
> * log4j configuration file for tests to show the output correctly
> 
> 
> This addresses bug SQOOP-762.
>     https://issues.apache.org/jira/browse/SQOOP-762
> 
> 
> Diffs
> -----
> 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartition.java
0e0e53fe7c9db96a4025e2feaf22b5fe9a01d3cc 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java
1f6714dcbb12916a6d350ad117c0bf4bac577a29 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java
7f1b14435f16eaa5e6d1563bfbe19d705ee4be3e 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java
36eb65d16048eff22ea9ded079a2827e978fcf06 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java fcedf52b8cbff1b727fd3b90360605a01d145e3d

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
976d80b66e4c1466350db432295232778893ab86 
>   execution/mapreduce/src/test/resources/log4j.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8562/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message