> On Dec. 12, 2012, 11:37 p.m., kturner wrote:
> > src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java, line 134
> > <https://reviews.apache.org/r/8559/diff/1/?file=237547#file237547line134>
> >
> > The buffer seems a bit large to me and the time seems small.
What values would you recommend? Should they be configurable with command-line options, perhaps?
> On Dec. 12, 2012, 11:37 p.m., kturner wrote:
> > src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java, line 132
> > <https://reviews.apache.org/r/8559/diff/1/?file=237552#file237552line132>
> >
> > The comment seems a bit off :)
Cut and paste will be the death of me.
> On Dec. 12, 2012, 11:37 p.m., kturner wrote:
> > src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java, line 132
> > <https://reviews.apache.org/r/8559/diff/1/?file=237547#file237547line132>
> >
> > Recommend doing the following to avoid race condition where another thread creates
table between exists check and call to create
> >
> > if (!conn.tableOperations().exists(tableName))
> > try{conn.tableOperations().create(tableName);} catch (TableExistsException
tee) {}
> >
> > Do not need exists check, but it will run faster with it in the case where the
table usually exists.
> >
Looking back, this create is actually redundant, as the other one should already have taken
care of it in the job setup.
- Philip
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8559/#review14403
-----------------------------------------------------------
On Dec. 12, 2012, 9:50 p.m., Philip Grim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8559/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2012, 9:50 p.m.)
>
>
> Review request for accumulo, Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Adds the ability to import to an Accumlo table in much the same manner as the current
HBase import capability. Reported in JIRA as ACCUMULO-141 and SQOOP-767.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/SqoopOptions.java 613f797
> src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java PRE-CREATION
> src/java/org/apache/sqoop/accumulo/AccumuloUtil.java PRE-CREATION
> src/java/org/apache/sqoop/accumulo/MutationTransformer.java PRE-CREATION
> src/java/org/apache/sqoop/accumulo/ToStringMutationTransformer.java PRE-CREATION
> src/java/org/apache/sqoop/manager/SqlManager.java 3a52c6d
> src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/AccumuloImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java d795646
> src/java/org/apache/sqoop/tool/ImportTool.java 10f0cb9
> src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8559/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Philip Grim
>
>
|