sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Jarcec Cecho (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-672) Unify logger usage across entire code base
Date Thu, 06 Dec 2012 22:21:10 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13525820#comment-13525820
] 

Jarek Jarcec Cecho commented on SQOOP-672:
------------------------------------------

Hi Venkat,
I'm excited to hear that you're interested in solving this issue. I would like to have unified
usage of logger in entire Sqoop 2 code base. At the top of my head:

* Have unified name for logger object across entire code base. I believe that we already have
this in place where all logger objects are called "LOG", but it do not hurts to verify that.

* Use the same logging packages and libraries. We're missing this one as for example:

{code:title=core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java}
import org.apache.log4j.Logger;
...
  private static final Logger LOG = Logger.getLogger(FrameworkManager.class);
{code}
{code:title=execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java}
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
...
  public static final Log LOG =
      LogFactory.getLog(SqoopMapper.class.getName());
{code}

Both files are using different packages and different idioms to get the logger object. I would
prefer to have that unified.


                
> Unify logger usage across entire code base
> ------------------------------------------
>
>                 Key: SQOOP-672
>                 URL: https://issues.apache.org/jira/browse/SQOOP-672
>             Project: Sqoop
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Jarek Jarcec Cecho
>            Priority: Minor
>              Labels: newbie
>             Fix For: 2.0.0
>
>
> We should unify same logging classes and logger names across entire code base.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message