sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-682 Use templating in job.etl classes
Date Fri, 04 Jan 2013 10:54:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8750/#review15075
-----------------------------------------------------------

Ship it!


LGTM

- Cheolsoo Park


On Dec. 23, 2012, 10:01 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8750/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2012, 10:01 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've change the classes to use generics, so that we don't have to use "Object" and explicit
retypes. I'm planning to clean up the ETL interface little bit more in near future, but I
want to submit clean and easily understandable patches, so I'll do it in separate JIRA/patch.
> 
> 
> This addresses bug SQOOP-682.
>     https://issues.apache.org/jira/browse/SQOOP-682
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java
37149decddc3c8f2523d0067b50b4ac077e9b7cc 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java
b56ca10db25428fc6ee4510b0f86e55a2ff999f3 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java
b2e59f75b1a8dc23f6f9c510371c4d5c45bc2863 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java
e09b0c3fac358669cfbbb1e885efc45fb622533d 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java
df78755fb51e49e5ece59f4ece9214ecb7a47cb5 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
3b697b6203030b5a7786070b186d225c361b4545 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
0d9f0c022aa7df41a2bd97541429dc293047f8de 
>   spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java 528d55059b19522be45c16d8ae635e6397a46469

>   spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java e824b98c46f1f94be67031ae7ef835bf21c507aa

>   spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 685378fbb20ae2f3a5406db1750a1add8e12aef3

>   spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 3148e496e00b6cb8272a5260cad656866963c561

>   spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 9cd000cb948207063d588a16e5b0d75ccb9525d3

> 
> Diff: https://reviews.apache.org/r/8750/diff/
> 
> 
> Testing
> -------
> 
> * Unit tests are passing
> * Briefly tested on real cluster
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message