sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-806 Sqoop2: Put "creation" and "lastUpdate" date to Connection and Job objects
Date Wed, 09 Jan 2013 20:40:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8801/#review15212
-----------------------------------------------------------

Ship it!


LGTM.

I also verified that show commands shows create and updated date as expected:

Connection with id 1 and name c (Created 1/9/13 12:36 PM, Updated 1/9/13 12:36 PM)
Job with id 1 and name j (Created 1/9/13 12:38 PM, Updated 1/9/13 12:38 PM)

- Cheolsoo Park


On Jan. 2, 2013, 3:33 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8801/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 3:33 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added proposed functionality.
> 
> 
> This addresses bug SQOOP-806.
>     https://issues.apache.org/jira/browse/SQOOP-806
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 17cb84a71a6833de9e6caef9a020cb2919f7fae0

>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java b0780ef48644813a374f37b99832b6e6ded3d6ca

>   client/src/main/resources/client-resource.properties 7bc7486a29a3663e4926e40c8b8623a829ac010f

>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java 4562047420879264ff27e5fcab63cb14b590bd01

>   common/src/main/java/org/apache/sqoop/json/JobBean.java 539efe03fae0edf5ce5baba6fcb14c0924f53709

>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java e4919b2ab0e03185ccfd407745b9063162a5a158

>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConnection.java 5af25a9fea472c1d0173fa9f813d4445b4aca247

>   common/src/main/java/org/apache/sqoop/model/MJob.java 87f222dd735fd3dd3982a9fd6b2ced719c89f19a

>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 24f175bd5690d69dc9dd0306eb9c83b17c922e89

>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java c11b600492446ada15a5cdf125db1a896b995723

>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 521b2b9751799529acd3980ad62f6deea98b5a55

>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
c62730ccd077663c763ece7df0c044acd437ffcc 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
875b41aad6e2e72fc6f110316532afbf4655a459 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
d0fd598c77e7b849e7a73b18344d7ed9ad7b7093 
> 
> Diff: https://reviews.apache.org/r/8801/diff/
> 
> 
> Testing
> -------
> 
> * I've added or enhanced existing unit tests
> * I've tested it on real cluster
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message