sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly
Date Wed, 23 Jan 2013 00:29:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8848/
-----------------------------------------------------------

(Updated Jan. 23, 2013, 12:29 a.m.)


Review request for Sqoop.


Changes
-------

I've incorporated Cheolsoo's comments.


Description
-------

I've fix methods toJson and fillValues() to work with new schema of configuration objects.


This addresses bug SQOOP-812.
    https://issues.apache.org/jira/browse/SQOOP-812


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/FormUtils.java 585d02eee14a004df45d6fa77dcde4bd65132088

  common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c80bd45947a364e9002db0e7ff0a2603ba75263d


Diff: https://reviews.apache.org/r/8848/diff/


Testing
-------

I've added new unit test.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message