sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly
Date Wed, 23 Jan 2013 00:29:09 GMT


> On Jan. 22, 2013, 11:51 p.m., Cheolsoo Park wrote:
> > Is it possible to add tests for enum type? It looks like the current test doesn't
cover enum type.

Good catch, I'll add test with Enumeration.


> On Jan. 22, 2013, 11:51 p.m., Cheolsoo Park wrote:
> > common/src/main/java/org/apache/sqoop/model/FormUtils.java, line 440
> > <https://reviews.apache.org/r/8848/diff/1/?file=245275#file245275line440>
> >
> >     Shouldn't this be "type.isEnum()"?

Excellent catch, thank you!


> On Jan. 22, 2013, 11:51 p.m., Cheolsoo Park wrote:
> > common/src/main/java/org/apache/sqoop/model/FormUtils.java, line 439
> > <https://reviews.apache.org/r/8848/diff/1/?file=245275#file245275line439>
> >
> >     Why can't we just do "(Integer)jsonInputs.get(inputName)"? Does this introduce
loss of precision?

Changing this as proposed will lead to following exception being thrown:

java.lang.ClassCastException: java.lang.Long cannot be cast to java.lang.Integer

The issue is that underlying JSON library serializes ints as long objects and thus we need
to retype them accordingly.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8848/#review15591
-----------------------------------------------------------


On Jan. 23, 2013, 12:29 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8848/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2013, 12:29 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've fix methods toJson and fillValues() to work with new schema of configuration objects.
> 
> 
> This addresses bug SQOOP-812.
>     https://issues.apache.org/jira/browse/SQOOP-812
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/FormUtils.java 585d02eee14a004df45d6fa77dcde4bd65132088

>   common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c80bd45947a364e9002db0e7ff0a2603ba75263d

> 
> Diff: https://reviews.apache.org/r/8848/diff/
> 
> 
> Testing
> -------
> 
> I've added new unit test.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message