sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: Hbase import fails if there is a row where all columns are null
Date Thu, 07 Feb 2013 02:59:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9300/#review16248
-----------------------------------------------------------


Hi David,
thank you very much for filling this bug and providing patch. Would you mind adding sentence
or two into the user guide documenting the behaviour?

Jarcec

- Jarek Cecho


On Feb. 5, 2013, 3:56 a.m., David Robson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9300/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 3:56 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Added defensive code to skip the HBase put and warn the user if it has no columns and
would therefore fail.
> Before this change it was crashing the whole Sqoop job.
> 
> 
> This addresses bug SQOOP-862.
>     https://issues.apache.org/jira/browse/SQOOP-862
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java cca641f 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java bf24608 
>   src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 65ff87b 
> 
> Diff: https://reviews.apache.org/r/9300/diff/
> 
> 
> Testing
> -------
> 
> Tested manually and created a new automated test for this case.
> 
> 
> Thanks,
> 
> David Robson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message