sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: Allow Sqoop to import row key column into HBase
Date Thu, 07 Feb 2013 19:36:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9354/#review16282
-----------------------------------------------------------


Hi David,
thank you very much your time. I have one small note:


src/docs/user/import.txt
<https://reviews.apache.org/r/9354/#comment34767>

    I found this quite confusing. For example saying something like:
    
      When set to +false+ (default), Sqoop will not add column used as a row key into the
row data in HBase. When set to +true+ , the column used as a row key will be added to the
row data in HBase.
    
    What do you thing?


Jarcec

- Jarek Cecho


On Feb. 7, 2013, 5:53 a.m., David Robson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9354/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 5:53 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Added new option to import row key column. Set to false by default (same behaviour as
before).
> Documented new option.
> 
> 
> This addresses bug SQOOP-870.
>     https://issues.apache.org/jira/browse/SQOOP-870
> 
> 
> Diffs
> -----
> 
>   src/docs/user/import.txt 9bc4fc9 
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java cca641f 
>   src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 131fd43 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java bf24608 
> 
> Diff: https://reviews.apache.org/r/9354/diff/
> 
> 
> Testing
> -------
> 
> Added tests for both options.
> 
> 
> Thanks,
> 
> David Robson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message