sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-880 Sqoop2: NPE when stopping job that was never executed
Date Sun, 10 Feb 2013 21:18:03 GMT


> On Feb. 10, 2013, 9:11 p.m., Cheolsoo Park wrote:
> > core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java, line 528
> > <https://reviews.apache.org/r/9391/diff/1/?file=257539#file257539line528>
> >
> >     Shouldn't you return if submission is null? At line 533 you do submission.getExternalId(),
so if submission is null, you will get a NPE again, no?

Yes of course, thank you for catching this.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9391/#review16408
-----------------------------------------------------------


On Feb. 9, 2013, 6:26 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9391/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2013, 6:26 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've fixed the NPE by adding explicit check.
> 
> 
> This addresses bug SQOOP-880.
>     https://issues.apache.org/jira/browse/SQOOP-880
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 6aab2db49e55c3152149d61f29dcf8d8a3f95ba5

> 
> Diff: https://reviews.apache.org/r/9391/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message