sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request: SQOOP-664 Send user name as HTTP header in client to server communication
Date Fri, 01 Mar 2013 18:36:07 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 1, 2013, 6:36 p.m.)

Review request for Sqoop and Jarek Cecho.


Using constant and following sqoop convention for custom headers.


commit cbbd044f7b3da77741f50c5a5082b57a3b49c1e2
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Fri Mar 1 00:56:18 2013 -0800

    SQOOP-664 Send user name as HTTP header in client to server communication
    Using a custom HTTP header "User-Name" following convention defined in rfc-6648.
    User name of user executing sqoop is sent to the server.

:100644 100644 1720507... 1b5d34c... M  client/src/main/java/org/apache/sqoop/client/request/Request.java
:100644 100644 c6b6569... 9685d96... M  server/src/main/java/org/apache/sqoop/server/RequestContext.java

This addresses bug SQOOP-664.

Diffs (updated)

  client/src/main/java/org/apache/sqoop/client/request/Request.java 17205070b87ac1904c055ba2d4fa7b773f2f3034

  common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java 93c786d7be26f2097ea83ef675e2d4a8c4938d60

  server/src/main/java/org/apache/sqoop/server/RequestContext.java c6b6569a9c19860fe8d1138040c1ffaa1ce5844e

Diff: https://reviews.apache.org/r/9683/diff/


Ran all unit tests and verified client is sending header to server.


Abraham Elmahrek

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message