sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-859 PostgreSQL: Test cases have hard coded username and password
Date Sat, 02 Mar 2013 00:13:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9582/#review17282
-----------------------------------------------------------

Ship it!


Ship It!

- Cheolsoo Park


On Feb. 25, 2013, 2:14 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9582/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 2:14 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've allowed the password, username and database to be overridden by system properties.
> 
> 
> This addresses bug SQOOP-859.
>     https://issues.apache.org/jira/browse/SQOOP-859
> 
> 
> Diffs
> -----
> 
>   src/test/com/cloudera/sqoop/manager/PostgresqlExportTest.java e85e62adf3c6330df5388f89969684fdbaf9f628

>   src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 3fadff71a950daae63523a7e49e887a8ef848ba3

> 
> Diff: https://reviews.apache.org/r/9582/diff/
> 
> 
> Testing
> -------
> 
> ant clean test -Dtestcase=PostgresqlImportTest -Dsqoop.test.postgresql.connectstring.host_url=jdbc:postgresql://postgresql/
-Dsqoop.test.postgresql.connectstring.username=sqoop -Dsqoop.test.postgresql.connectstring.database=sqoop
-Dsqoop.test.postgresql.connectstring.password=sqoop
> 
> ant clean test -Dtestcase=PostgresqlExportTest -Dsqoop.test.postgresql.connectstring.host_url=jdbc:postgresql://postgresql/
-Dsqoop.test.postgresql.connectstring.username=sqoop -Dsqoop.test.postgresql.connectstring.database=sqoop
-Dsqoop.test.postgresql.connectstring.password=sqoop
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message