sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Linden Hillenbrand" <lin...@cloudera.com>
Subject Re: Review Request: Cleaned up error codes in MapreduceExecutionError
Date Sat, 02 Mar 2013 15:49:48 GMT


> On Feb. 18, 2013, 8:31 p.m., Jarek Cecho wrote:
> > execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java,
line 27
> > <https://reviews.apache.org/r/9495/diff/1/?file=259570#file259570line27>
> >
> >     Would you mind keeping this around? I know that it's unused, but we're trying
to reserve the error code 0000 to unknown issues across entire code base.

Agreed, I will clean the gaps and also it makes sense to keep '0000' around, I'll re-grep
the codebase to see where that is used as well just as an FYI for my sake.


- Linden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9495/#review16714
-----------------------------------------------------------


On Feb. 18, 2013, 4:32 p.m., Linden Hillenbrand wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9495/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 4:32 p.m.)
> 
> 
> Review request for Sqoop, Jarek Cecho and Kathleen Ting.
> 
> 
> Description
> -------
> 
> Checked each error in MapreduceExecutionError.java and kept ones referenced in the code
base and cleaned up the ones that were not being used.
> 
> The ones I was able to remove are the following:
> 
> /** Error occurs during job execution. */
> MAPRED_EXEC_0008("Error occurs during job execution"),
> 
> /** The system was unable to load the specified class. */
> MAPRED_EXEC_0009("Unable to load the specified class"),
> 
> /** The parameter already exists in the context */
> MAPRED_EXEC_0011("The parameter already exists in the context"),
> 
> /** Cannot read from the data reader */
> MAPRED_EXEC_0014("Cannot read to the data reader"),
> 
> /** Unable to write data due to interrupt */
> MAPRED_EXEC_0015("Unable to write data due to interrupt"),
> 
> /** Unable to read data due to interrupt */
> MAPRED_EXEC_0016("Unable to read data due to interrupt"),
> 
> /** The required option has not been set yet */
> MAPRED_EXEC_0020("The required option has not been set yet"),
> 
> 
> This addresses bug Sqoop-743.
>     https://issues.apache.org/jira/browse/Sqoop-743
> 
> 
> Diffs
> -----
> 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java
1dc12d1 
> 
> Diff: https://reviews.apache.org/r/9495/diff/
> 
> 
> Testing
> -------
> 
> Ran all tests and passed successfully.
> 
> 
> Thanks,
> 
> Linden Hillenbrand
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message