sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-846 Provide Netezza connector
Date Sat, 02 Mar 2013 23:02:27 GMT


> On March 2, 2013, 7:26 p.m., Jarek Cecho wrote:
> > Hi Venkat,
> > thank you very much for incorporating all my suggestions. I believe that we're almost
there! I do have just couple of additional high level notes and few comments (mostly just
nits):
> > 
> > 1) Tests are passing for me - it was something specific to my environment. Thank
you for checking though!
> > 
> > 2) The docs are not compiling for me:
> > 
> >      [exec] asciidoc: ERROR: connectors.txt: line 288: [blockdef-listing] missing
closing delimiter
> > 
> > 3) I would like to see more tests, especially about testing the various extra arguments.
But I'm open to resolve that in follow up jira. No need to postpone this task even further.
> 
> Venkat Ranganathan wrote:
>     Thanks Jarek for reviewing and feedback.
>     
>     1)  Great - I could run it with NPS 6 and 7.  And glad that it is now passing for
you.   
>     2)  Fixed the docs.
>     3)  I agree.   I have couple of manual tests but will integrate them by filing followon
JIRAs
>     
>     Will update new patch after testing and making sure the documentation is in order
also
>     
>     Thanks
>     Venkat

Thank you for your quick feedback sir!


> On March 2, 2013, 7:26 p.m., Jarek Cecho wrote:
> > src/java/org/apache/sqoop/manager/NetezzaManager.java, line 96
> > <https://reviews.apache.org/r/9543/diff/8/?file=263540#file263540line96>
> >
> >     Shouldn't be safer operation to rollback instead of commit here? I would expect
that the rest of code will commit any changes that it needed to do prior calling close method.
> 
> Venkat Ranganathan wrote:
>     Yes.  That is true.  It seems that this is a carry over from the PostgresqlManager.
  I will file a JIRA to fix the PostgresqlManager also

Agreed, please go ahead and file that JIRA for PostgreSQL.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9543/#review17303
-----------------------------------------------------------


On Feb. 28, 2013, 8:06 a.m., Venkat Ranganathan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9543/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2013, 8:06 a.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Description
> -------
> 
> This addresses SQOOP-846 (provide a Netezza connector)
> 
> 
> This addresses bug SQOOP-846.
>     https://issues.apache.org/jira/browse/SQOOP-846
> 
> 
> Diffs
> -----
> 
>   src/docs/user/connectors.txt 7dd2a2e 
>   src/java/org/apache/sqoop/lib/DelimiterSet.java 4e9bcab 
>   src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 54eb258 
>   src/java/org/apache/sqoop/manager/DirectNetezzaManager.java PRE-CREATION 
>   src/java/org/apache/sqoop/manager/MySQLUtils.java ef18818 
>   src/java/org/apache/sqoop/manager/NetezzaManager.java PRE-CREATION 
>   src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaDBDataSliceSplitter.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableExportMapper.java
PRE-CREATION 
>   src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java
PRE-CREATION 
>   src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableRecordExportMapper.java
PRE-CREATION 
>   src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableTextExportMapper.java
PRE-CREATION 
>   src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaJDBCStatementRunner.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/netezza/NetezzaDataDrivenDBInputFormat.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/netezza/NetezzaExternalTableExportJob.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/netezza/NetezzaExternalTableImportJob.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/netezza/NetezzaExternalTableInputFormat.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/netezza/NetezzaExternalTableInputSplit.java PRE-CREATION

>   src/test/com/cloudera/sqoop/manager/DirectNetezzaExportManualTest.java PRE-CREATION

>   src/test/com/cloudera/sqoop/manager/NetezzaImportManualTest.java PRE-CREATION 
>   src/test/com/cloudera/sqoop/manager/NetezzaTestUtils.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9543/diff/
> 
> 
> Testing
> -------
> 
> Ran all sqoop tests.   Ran Netezza manual tests against Netezza VMs version 6 and 7
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message