sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: Sqoop2: Print out warnings in client shell for objects created with status ACCEPTABLE
Date Sun, 24 Mar 2013 14:55:37 GMT


On March 5, 2013, 4:45 a.m., vasanthkumar wrote:
> > Jarcec
> 
> Jarek Cecho wrote:
>     Hi Vasanth,
>     thank you very much for working on this JIRA. Your contribution is greatly appreciated.
I wanted to check with you if you are still intending to work on this patch or whether you
would prefer if anyone else would take a look?
>     
>     Jarcec
> 
> vasanthkumar wrote:
>     Hi Jarcec,
>     I have small clarification. Already you have given comment: " "instanceof" much siimpler
as it will introduce common ancestor to both MConnection and Mjob classes". But MConnection,
MJob and MSubmission are sharing same parent. Then Forms are managed in MConnection and MJob,
not its ancestor. Please suggest for avoiding the instanceof.
>     
>     Vasanth kumar

Yeah you're right, I was referring to my planned changes in SQOOP-919 where I've introduced
new class MFormList. I think that that particular comment no longer applies.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9729/#review17376
-----------------------------------------------------------


On March 4, 2013, 8:53 a.m., vasanthkumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9729/
> -----------------------------------------------------------
> 
> (Updated March 4, 2013, 8:53 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Print out warnings in client shell for objects created with status ACCEPTABLE 
> 
> 
> This addresses bug SQOOP-920.
>     https://issues.apache.org/jira/browse/SQOOP-920
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 2c750d3

>   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 1f01cc7 
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java 5632bac 
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java dd0df24

>   client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java 4fac977 
> 
> Diff: https://reviews.apache.org/r/9729/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> vasanthkumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message