sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmed El Baz" <ahel...@microsoft.com>
Subject Re: Review Request: Request to review patch for SQOOP-954: Create Sqoop runtime scripts to run Sqoop on Windows
Date Mon, 22 Apr 2013 17:05:34 GMT


> On April 22, 2013, 7:06 a.m., Venkat Ranganathan wrote:
> > bin/configure-sqoop.cmd, line 71
> > <https://reviews.apache.org/r/10055/diff/3/?file=283030#file283030line71>
> >
> >     Shouldn't this be HADOOP_COMMON_HOME without % around it - Otherwise it would
be expanded to null string, right?

Hi Venkat,

The echo is done in a if exist block which only checks if the given path exists or refers
to a a file/dir which does not exist. The case you are referring to should be caught earlier
in the "if not defined HADOOP_COMMON_HOME" block.

Thanks


> On April 22, 2013, 7:06 a.m., Venkat Ranganathan wrote:
> > bin/configure-sqoop.cmd, line 77
> > <https://reviews.apache.org/r/10055/diff/3/?file=283030#file283030line77>
> >
> >     See previous comment

same response as above


> On April 22, 2013, 7:06 a.m., Venkat Ranganathan wrote:
> > bin/configure-sqoop.cmd, line 82
> > <https://reviews.apache.org/r/10055/diff/3/?file=283030#file283030line82>
> >
> >     Same as above

Same response as above

Thank you


> On April 22, 2013, 7:06 a.m., Venkat Ranganathan wrote:
> > bin/configure-sqoop.cmd, line 129
> > <https://reviews.apache.org/r/10055/diff/3/?file=283030#file283030line129>
> >
> >     Wouldn't HADOOP_CLASSPATH be additive - that is subsequent invocations will
be adding to the HADOOP_CLASSPATH with the same values again and again (it is something like
always calling . bin/sqoop in Unix systems.   Should there be a setlocal either in this

Thanks Venkat,

There is already a setlocal in the parent script (sqoop.cmd) which calls into this script
(configure-sqoop.cmd).
Thanks,

Ahmed


- Ahmed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10055/#review19517
-----------------------------------------------------------


On April 22, 2013, 3:26 a.m., Ahmed El Baz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10055/
> -----------------------------------------------------------
> 
> (Updated April 22, 2013, 3:26 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> A patch implementing the Windows version of Sqoop run scripts. The scripts follow the
same logic as there .sh counterparts.
> One difference is to create a Jar which references all classpath elements in its Manifest,
and provide that jar as the single jar needed for Sqoop. The reason here is that in some cases
if the number of classpath elements is large, HADOOP_CLASSPATH gets very long which causes
failures in Windows since there is a limit to command lines.
> As a workaround, I added a step to wrap all jars in the classpath in a single jar, and
then use that generated jar (this is also done in hadoop for Windows to handle similar issues)
> I did this in a utility script "BuildJar" which can be used for other components as well.
> This change is specific to Windows scripts, Linux scripts are not affected.
> 
> 
> This addresses bug SQOOP-954.
>     https://issues.apache.org/jira/browse/SQOOP-954
> 
> 
> Diffs
> -----
> 
>   bin/configure-sqoop.cmd PRE-CREATION 
>   bin/sqoop.cmd PRE-CREATION 
>   conf/sqoop-env-template.cmd PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10055/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ahmed El Baz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message