sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmed El Baz" <ahel...@microsoft.com>
Subject Re: Review Request: Request to review patch for SQOOP-954: Create Sqoop runtime scripts to run Sqoop on Windows
Date Tue, 23 Apr 2013 04:04:59 GMT


> On April 22, 2013, 11:04 p.m., Venkat Ranganathan wrote:
> > bin/configure-sqoop.cmd, line 71
> > <https://reviews.apache.org/r/10055/diff/3/?file=283030#file283030line71>
> >
> >     Ahmed
> >     
> >     If you do this test on Windows in a batch file
> >     
> >     if not exist %dir% (
> >        statements
> >     )
> >     then the statements will be executed even if %dir% is undefined.   Can you verify
that

Thank you Venkat,

Yes I know this but if you look at the script you will see that in the case where if not defined
HADOOP_COMMON_HOME and HADOOP_MAPRED_HOME are not defined, we print an error message and exit
the script, so the print statement "echo Error: %HADOOP_MAPRED_HOME% does not exist!" is not
reachable in this case.

I do not think it makes a big difference if I display the variable name, so I will make this
change and upload a patch.

Thank you Venkat.
Ahmed


- Ahmed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10055/#review19557
-----------------------------------------------------------


On April 22, 2013, 3:26 a.m., Ahmed El Baz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10055/
> -----------------------------------------------------------
> 
> (Updated April 22, 2013, 3:26 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> A patch implementing the Windows version of Sqoop run scripts. The scripts follow the
same logic as there .sh counterparts.
> One difference is to create a Jar which references all classpath elements in its Manifest,
and provide that jar as the single jar needed for Sqoop. The reason here is that in some cases
if the number of classpath elements is large, HADOOP_CLASSPATH gets very long which causes
failures in Windows since there is a limit to command lines.
> As a workaround, I added a step to wrap all jars in the classpath in a single jar, and
then use that generated jar (this is also done in hadoop for Windows to handle similar issues)
> I did this in a utility script "BuildJar" which can be used for other components as well.
> This change is specific to Windows scripts, Linux scripts are not affected.
> 
> 
> This addresses bug SQOOP-954.
>     https://issues.apache.org/jira/browse/SQOOP-954
> 
> 
> Diffs
> -----
> 
>   bin/configure-sqoop.cmd PRE-CREATION 
>   bin/sqoop.cmd PRE-CREATION 
>   conf/sqoop-env-template.cmd PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10055/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ahmed El Baz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message