sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: Sqoop2: sqoop.sh execution error
Date Wed, 01 May 2013 16:48:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/#review20008
-----------------------------------------------------------


Thank you Vasanth,
I do have just two nits:


dist/src/main/bin/sqoop.sh
<https://reviews.apache.org/r/10689/#comment41240>

    Can we remove this line? The BASEDIR is being printed out later in more user friendly
manner.



dist/src/main/bin/sqoop.sh
<https://reviews.apache.org/r/10689/#comment41241>

    I think that those two lines are not necessary at this point. We might need to change
all CUR_DIR occurrences to BASEDIR though.


Jarcec

- Jarek Cecho


On April 21, 2013, 1:02 p.m., vasanthkumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10689/
> -----------------------------------------------------------
> 
> (Updated April 21, 2013, 1:02 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Problem while starting and stopping sqoop server.
> Patch supports softlink for both server and client command. 
> 
> 
> This addresses bug SQOOP-1003.
>     https://issues.apache.org/jira/browse/SQOOP-1003
> 
> 
> Diffs
> -----
> 
>   dist/src/main/bin/sqoop.sh a218441 
> 
> Diff: https://reviews.apache.org/r/10689/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> vasanthkumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message