sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Re: Review Request: Review request for SQOOP-1033 "CombineFileInputFormat does not work with paths not on default FS like ASV"
Date Thu, 09 May 2013 21:57:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10988/#review20402
-----------------------------------------------------------



src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java
<https://reviews.apache.org/r/10988/#comment42036>

    Can you please remove the spaces


- Venkat Ranganathan


On May 8, 2013, 8:12 p.m., Shuaishuai Nie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10988/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 8:12 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> CombineFileInputFormat does not work with ASV. This appeared as an issue in Sqoop which
failed to export files in ASV. CombineFileInputFormat strips out the scheme and authority
components of the path, after which point the path is assumed to be on the default file system.
>  Sqoop has it own copy of CombineFileInputFormat, but updated the ones in core as well
for consistency.
> 
> There are currently already solved Jiras for the same issue:
> https://issues.apache.org/jira/browse/MAPREDUCE-2704
> https://issues.apache.org/jira/browse/MAPREDUCE-1806
> 
> 
> This addresses bug SQOOP-1033.
>     https://issues.apache.org/jira/browse/SQOOP-1033
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java 7d2be38 
> 
> Diff: https://reviews.apache.org/r/10988/diff/
> 
> 
> Testing
> -------
> 
> Tested in ASV manually
> 
> 
> Thanks,
> 
> Shuaishuai Nie
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message