sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: Export dir to support subdirectories
Date Mon, 20 May 2013 13:48:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10646/#review20764
-----------------------------------------------------------


Hi Vasanth,
thank you very much for working on this patch, greatly appreciated! Would you mind introducing
test case that will cover the new introduced functionality?


src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
<https://reviews.apache.org/r/10646/#comment42860>

    I don't feel entirely comfortable about this as it will change behavior of the default
input format that is skipping certain names. For example files/directories starting with dot
or underscore are normally skipped.
    
    Perhaps we could introduce new parameter like --recursive-export that will be properly
documented? 


Jarcec

- Jarek Cecho


On April 19, 2013, 12:02 p.m., vasanthkumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10646/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 12:02 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Export dir to support subdirectories
> 
> 
> This addresses bug SQOOP-951.
>     https://issues.apache.org/jira/browse/SQOOP-951
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java 7d2be38 
>   src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 1065d0b 
> 
> Diff: https://reviews.apache.org/r/10646/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> vasanthkumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message