sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shruti Joshi" <shruti_jo...@persistent.co.in>
Subject Re: Review Request: Fix for SQOOP-107
Date Thu, 23 May 2013 07:52:47 GMT


> On May 21, 2013, 8:56 a.m., Jarek Cecho wrote:
> > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java, lines 42-43
> > <https://reviews.apache.org/r/11041/diff/1/?file=289945#file289945line42>
> >
> >     Nit: Is this change necessary?

No.. This change is not necassary..


> On May 21, 2013, 8:56 a.m., Jarek Cecho wrote:
> > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java, lines 48-49
> > <https://reviews.apache.org/r/11041/diff/1/?file=289945#file289945line48>
> >
> >     Nit: Is this change necessary?

No.. This change is also not necessary..


> On May 21, 2013, 8:56 a.m., Jarek Cecho wrote:
> > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java, lines 68-69
> > <https://reviews.apache.org/r/11041/diff/1/?file=289945#file289945line68>
> >
> >     Nit: Is this change necessary?

No.. This is also not necessary..


- Shruti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11041/#review20831
-----------------------------------------------------------


On May 22, 2013, 1:22 p.m., Shruti Joshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11041/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 1:22 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Sqoop does not support importing data into hbase when table contains composite key.
> 
> 
> This addresses bug https://issues.cloudera.org/browse/SQOOP-107.
>     https://issues.apache.org/jira/browse/https://issues.cloudera.org/browse/SQOOP-107
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 6aca97f 
>   src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 13c765c 
>   src/java/org/apache/sqoop/tool/VersionTool.java bcd824d 
> 
> Diff: https://reviews.apache.org/r/11041/diff/
> 
> 
> Testing
> -------
> 
> ant test (default) was a success.
> 
> 
> Thanks,
> 
> Shruti Joshi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message