sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <raghavgau...@gmail.com>
Subject Re: Review Request: Fix for Sqoop-976: Incremental import with text column as criteria should fail early
Date Mon, 03 Jun 2013 20:47:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11524/
-----------------------------------------------------------

(Updated June 3, 2013, 8:47 p.m.)


Review request for Sqoop.


Changes
-------

Made changes suggested by Jarek.


Description
-------

Incremental import with text column as criteria should fail fast. The patch does this.


This addresses bug SQOOP-976.
    https://issues.apache.org/jira/browse/SQOOP-976


Diffs (updated)
-----

  src/docs/user/import.txt ee10b1c 
  src/java/org/apache/sqoop/manager/ConnManager.java a1ac38e 
  src/java/org/apache/sqoop/tool/ImportTool.java 2627726 
  src/test/com/cloudera/sqoop/TestIncrementalImport.java cab77ec 

Diff: https://reviews.apache.org/r/11524/diff/


Testing
-------

I have added new test for this and all the tests pass.


Thanks,

Raghav Gautam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message