sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mengwei Ding" <mengwei.d...@cloudera.com>
Subject Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'
Date Wed, 05 Jun 2013 18:01:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11535/
-----------------------------------------------------------

(Updated June 5, 2013, 6:01 p.m.)


Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.


Changes
-------

Ignoring host, port and webapp option, when url option is given.


Summary (updated)
-----------------

SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp
in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'


Description (updated)
-------

commit 31a39620c4f102f0eb23958a571d220ee5aa721d
Author: Mengwei Ding <mengwei.ding@cloudera.com>
Date:   Wed May 29 18:04:53 2013 -0700

    SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp
in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'

:100644 100644 979b892... 2fd4948... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 1c85592... 41fc17a... M	client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java
:100644 100644 5dbcef5... 9f9289e... M	client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
:100644 100644 e328f9a... afc1ced... M	client/src/main/resources/client-resource.properties
:100644 100644 33419b9... cc3c364... M	docs/src/site/sphinx/CommandLineClient.rst


This addresses bug SQOOP-973.
    https://issues.apache.org/jira/browse/SQOOP-973


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892 
  client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java 1c85592 
  client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5 
  client/src/main/resources/client-resource.properties e328f9a 
  docs/src/site/sphinx/CommandLineClient.rst 33419b9 

Diff: https://reviews.apache.org/r/11535/diff/


Testing
-------


Thanks,

Mengwei Ding


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message