sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <raghavgau...@gmail.com>
Subject Re: Review Request: Review request for SQOOP-883: Adds a --delete-target-dir option
Date Thu, 06 Jun 2013 03:56:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11517/
-----------------------------------------------------------

(Updated June 6, 2013, 3:56 a.m.)


Review request for Sqoop.


Changes
-------

Updated diff incorporates all the comments.


Description
-------

After first import, re-importing to a directory fails because the directory already exists.
This patch tries to fix that by providing a --delete-target-dir option. This option will delete
the target directory of the import before running the import if it exists.


Diffs (updated)
-----

  src/docs/user/import.txt ee10b1c 
  src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java a5f72f7 
  src/java/org/apache/sqoop/SqoopOptions.java f18d43e 
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 42f521f 
  src/java/org/apache/sqoop/tool/ImportTool.java 2627726 
  src/test/com/cloudera/sqoop/TestSqoopOptions.java c78cd87 
  src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java 6ab3b82 

Diff: https://reviews.apache.org/r/11517/diff/


Testing
-------

Added new test for the option.
All the tests pass.


Thanks,

Raghav Gautam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message