sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Re: Review Request: Review request for SQOOP-883: Adds a --delete-target-dir option
Date Mon, 10 Jun 2013 23:32:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11517/#review21677
-----------------------------------------------------------

Ship it!


Ship It!

- Venkat Ranganathan


On June 10, 2013, 9:29 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11517/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 9:29 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> After first import, re-importing to a directory fails because the directory already exists.
This patch tries to fix that by providing a --delete-target-dir option. This option will delete
the target directory of the import before running the import if it exists.
> 
> 
> Diffs
> -----
> 
>   src/docs/user/import.txt 4a9a316 
>   src/java/org/apache/sqoop/SqoopOptions.java 4be6a6a 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 01a55e5 
>   src/java/org/apache/sqoop/tool/ImportTool.java 1c57503 
>   src/test/com/cloudera/sqoop/TestSqoopOptions.java c78cd87 
>   src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java 6ab3b82 
> 
> Diff: https://reviews.apache.org/r/11517/diff/
> 
> 
> Testing
> -------
> 
> Added new test for the option.
> All the tests pass.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message