sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shuaishuai Nie" <shuai...@microsoft.com>
Subject Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter tests to repo"
Date Wed, 12 Jun 2013 17:30:04 GMT


> On June 3, 2013, 10:36 a.m., Abhijeet Gaikwad wrote:
> > conf/MSTest.properties, line 1
> > <https://reviews.apache.org/r/10987/diff/5/?file=295730#file295730line1>
> >
> >     Some unused properties in this file.

removed unused properties in the file


> On June 3, 2013, 10:36 a.m., Abhijeet Gaikwad wrote:
> > src/test/org/apache/sqoop/manager/MSSQLTestUtils.java, line 46
> > <https://reviews.apache.org/r/10987/diff/5/?file=295735#file295735line46>
> >
> >     We can remove these privates.

removed from code


- Shuaishuai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21310
-----------------------------------------------------------


On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 5:55 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the
repo.
> 
> 
> This addresses bug SQOOP-1035.
>     https://issues.apache.org/jira/browse/SQOOP-1035
> 
> 
> Diffs
> -----
> 
>   conf/MSTest.properties PRE-CREATION 
>   src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1 
>   src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2 
>   src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION

>   src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION 
>   testdata/DatatypeTestData-export-lite.txt PRE-CREATION 
>   testdata/DatatypeTestData-import-lite.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10987/diff/
> 
> 
> Testing
> -------
> 
> All tests passing after applying the patch
> 
> 
> Thanks,
> 
> Shuaishuai Nie
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message